From a28790d194ee1d7635dddc9ecf53fbdbcf1227c4 Mon Sep 17 00:00:00 2001 From: Gros Frumos Date: Mon, 16 Mar 2026 10:06:01 +0200 Subject: [PATCH] =?UTF-8?q?kin:=20KIN-073=20=D0=94=D0=BE=D0=B1=D0=B0=D0=B2?= =?UTF-8?q?=D0=B8=D1=82=D1=8C=20=D0=BF=D0=BE=D0=BB=D0=B5=20acceptance=5Fcr?= =?UTF-8?q?iteria=20=D0=B2=20=D1=82=D0=B0=D0=B1=D0=BB=D0=B8=D1=86=D1=83=20?= =?UTF-8?q?tasks.=20=D0=9F=D1=80=D0=B8=20=D1=81=D0=BE=D0=B7=D0=B4=D0=B0?= =?UTF-8?q?=D0=BD=D0=B8=D0=B8=20=D0=B7=D0=B0=D0=B4=D0=B0=D1=87=D0=B8=20?= =?UTF-8?q?=E2=80=94=20=D0=BE=D1=82=D0=B4=D0=B5=D0=BB=D1=8C=D0=BD=D0=BE?= =?UTF-8?q?=D0=B5=20=D0=BF=D0=BE=D0=BB=D0=B5=20=D0=BE=D0=BF=D0=B8=D1=81?= =?UTF-8?q?=D1=8B=D0=B2=D0=B0=D1=8E=D1=89=D0=B5=D0=B5=20=D1=87=D1=82=D0=BE?= =?UTF-8?q?=20=D0=B4=D0=BE=D0=BB=D0=B6=D0=BD=D0=BE=20=D0=B1=D1=8B=D1=82?= =?UTF-8?q?=D1=8C=20=D0=BD=D0=B0=20=D0=B2=D1=8B=D1=85=D0=BE=D0=B4=D0=B5.?= =?UTF-8?q?=20PM=20=D0=BF=D0=BE=D0=BB=D1=83=D1=87=D0=B0=D0=B5=D1=82=20acce?= =?UTF-8?q?ptance=5Fcriteria=20=D0=B8=20=D0=B8=D1=81=D0=BF=D0=BE=D0=BB?= =?UTF-8?q?=D1=8C=D0=B7=D1=83=D0=B5=D1=82=20=D0=B4=D0=BB=D1=8F=20=D0=BF?= =?UTF-8?q?=D1=80=D0=BE=D0=B2=D0=B5=D1=80=D0=BA=D0=B8=20=D0=B7=D0=B0=D0=B2?= =?UTF-8?q?=D0=B5=D1=80=D1=88=D1=91=D0=BD=D0=BD=D0=BE=D1=81=D1=82=D0=B8,?= =?UTF-8?q?=20=D0=BD=D0=B5=20=D0=BF=D1=83=D1=82=D0=B0=D0=B5=D1=82=20=D1=81?= =?UTF-8?q?=20=D1=82=D0=B5=D0=BA=D1=83=D1=89=D0=B8=D0=BC=20=D1=81=D0=BE?= =?UTF-8?q?=D1=81=D1=82=D0=BE=D1=8F=D0=BD=D0=B8=D0=B5=D0=BC.=20GUI:=20text?= =?UTF-8?q?area=20'=D0=9A=D1=80=D0=B8=D1=82=D0=B5=D1=80=D0=B8=D0=B8=20?= =?UTF-8?q?=D0=BF=D1=80=D0=B8=D1=91=D0=BC=D0=BA=D0=B8'=20=D0=B2=20=D1=84?= =?UTF-8?q?=D0=BE=D1=80=D0=BC=D0=B5=20=D1=81=D0=BE=D0=B7=D0=B4=D0=B0=D0=BD?= =?UTF-8?q?=D0=B8=D1=8F=20=D0=B7=D0=B0=D0=B4=D0=B0=D1=87=D0=B8.=20Tester?= =?UTF-8?q?=20=D0=B8=20reviewer=20=D1=82=D0=BE=D0=B6=D0=B5=20=D0=BF=D0=BE?= =?UTF-8?q?=D0=BB=D1=83=D1=87=D0=B0=D1=8E=D1=82=20acceptance=5Fcriteria=20?= =?UTF-8?q?=D0=B4=D0=BB=D1=8F=20=D0=BF=D1=80=D0=BE=D0=B2=D0=B5=D1=80=D0=BA?= =?UTF-8?q?=D0=B8.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- tests/test_db.py | 85 +++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 84 insertions(+), 1 deletion(-) diff --git a/tests/test_db.py b/tests/test_db.py index 5cdf5ac..6514bbf 100644 --- a/tests/test_db.py +++ b/tests/test_db.py @@ -1,4 +1,4 @@ -"""Tests for core/db.py — schema and migration (KIN-071).""" +"""Tests for core/db.py — schema and migration (KIN-071, KIN-073).""" import sqlite3 import pytest @@ -200,3 +200,86 @@ def test_migrate_operations_project_with_null_path(): assert row["path"] is None assert row["project_type"] == "operations" conn.close() + + +# --------------------------------------------------------------------------- +# Schema KIN-073: acceptance_criteria в таблице tasks +# --------------------------------------------------------------------------- + +class TestTasksAcceptanceCriteriaSchema: + """Колонка acceptance_criteria присутствует в таблице tasks.""" + + def test_schema_has_acceptance_criteria_column(self, conn): + assert "acceptance_criteria" in _cols(conn, "tasks") + + def test_acceptance_criteria_defaults_to_null(self, conn): + """Создание задачи без acceptance_criteria — поле NULL (nullable).""" + conn.execute( + "INSERT INTO projects (id, name, path) VALUES ('p1', 'P', '/p')" + ) + conn.execute( + "INSERT INTO tasks (id, project_id, title) VALUES ('t1', 'p1', 'My Task')" + ) + conn.commit() + row = conn.execute( + "SELECT acceptance_criteria FROM tasks WHERE id='t1'" + ).fetchone() + assert row["acceptance_criteria"] is None + + def test_create_task_with_acceptance_criteria_saves_field(self, conn): + """Создание задачи с acceptance_criteria — значение сохраняется в БД.""" + conn.execute( + "INSERT INTO projects (id, name, path) VALUES ('p2', 'P', '/p')" + ) + criteria = "Поле должно сохраняться. GET возвращает значение." + conn.execute( + "INSERT INTO tasks (id, project_id, title, acceptance_criteria)" + " VALUES ('t2', 'p2', 'Task with criteria', ?)", + (criteria,), + ) + conn.commit() + row = conn.execute( + "SELECT acceptance_criteria FROM tasks WHERE id='t2'" + ).fetchone() + assert row["acceptance_criteria"] == criteria + + def test_get_task_returns_acceptance_criteria(self, conn): + """SELECT задачи возвращает acceptance_criteria (критерий приёмки 3).""" + conn.execute( + "INSERT INTO projects (id, name, path) VALUES ('p3', 'P', '/p')" + ) + conn.execute( + "INSERT INTO tasks (id, project_id, title, acceptance_criteria)" + " VALUES ('t3', 'p3', 'T', 'AC value')", + ) + conn.commit() + row = conn.execute("SELECT * FROM tasks WHERE id='t3'").fetchone() + assert row["acceptance_criteria"] == "AC value" + + +# --------------------------------------------------------------------------- +# Migration KIN-073: _migrate добавляет acceptance_criteria в старую схему +# --------------------------------------------------------------------------- + +def test_migrate_adds_acceptance_criteria_to_old_schema(): + """_migrate добавляет acceptance_criteria в tasks если колонки нет.""" + conn = _old_schema_conn() + _migrate(conn) + assert "acceptance_criteria" in _cols(conn, "tasks") + conn.close() + + +def test_migrate_acceptance_criteria_is_nullable_after_migration(): + """После миграции acceptance_criteria nullable — старые строки не ломаются.""" + conn = _old_schema_conn() + conn.execute( + "INSERT INTO projects (id, name, path) VALUES ('pm', 'P', '/p')" + ) + conn.execute( + "INSERT INTO tasks (id, project_id, title) VALUES ('tm', 'pm', 'Old Task')" + ) + conn.commit() + _migrate(conn) + row = conn.execute("SELECT acceptance_criteria FROM tasks WHERE id='tm'").fetchone() + assert row["acceptance_criteria"] is None + conn.close()